[GitHub] spark pull request #13577: [Minor][Doc] Improve SQLContext Documentation and...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13577


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #13577: [Minor][Doc] Improve SQLContext Documentation and...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13577#discussion_r66529939
  
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -346,15 +346,68 @@ class SQLContext private[sql](val sparkSession: 
SparkSession)
 sparkSession.createDataFrame(rowRDD, schema, needsConversion)
   }
 
-
+  /**
+   * Creates a [[Dataset]] from a local Seq of data of a given type. This 
method requires an
+   * encoder (to convert a JVM object of type `T` to and from the internal 
Spark SQL representation)
+   * that is generally created automatically through implicits from a 
`SparkSession`, or can be
+   * created explicitly by calling static methods on [[Encoders]].
+   *
+   * == Example ==
--- End diff --

what does this look like when it is rendered? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #13577: [Minor][Doc] Improve SQLContext Documentation and...

[techaddict]

GitHub user techaddict opened a pull request:

https://github.com/apache/spark/pull/13577

[Minor][Doc] Improve SQLContext Documentation and Fix SparkSession and 
sql.functions Documentation

## What changes were proposed in this pull request?
1. In SparkSession, add emptyDataset to dataset group and fix groupname 
mapping
3. Add documentation for createDataset for SQLContext
4. Fix the documentation of `months_between` in functions

## How was this patch tested?
Verified manually by generating api docs using `build/sbt 
spark/scalaunidoc:doc`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/techaddict/spark minor-5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13577.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13577


commit 9844808f70cc926c86b29df141e2660086571b7d
Author: Sandeep Singh 
Date:   2016-06-09T12:22:49Z

[Minor][Doc] In SparkSession, add emptyDataset to dataset group

commit dbccfbf6492388b9f26cc4ec8365f1a3a6e111b3
Author: Sandeep Singh 
Date:   2016-06-09T12:31:44Z

Fix months_between's documentation in sql functions

commit 0f22de020f3b6935810d935481fcbe0dfc420ff5
Author: Sandeep Singh 
Date:   2016-06-09T12:41:45Z

Add Documentation to SqlContext's createDataset Methods

commit 41f696d87203098e4de34d88625c846024674a02
Author: Sandeep Singh 
Date:   2016-06-09T12:46:13Z

Add groupNames to SparkSession

commit 1e05d6d470ce35b6f38c1a5df2b3c6315439169f
Author: Sandeep Singh 
Date:   2016-06-09T12:48:34Z

nit




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org