[GitHub] spark pull request #13589: [SPARK-15822][SPARK-15825][SQL] Fix SMJ Segfault/...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/13589#discussion_r66615434
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
@@ -490,6 +490,7 @@ class CodegenContext {
   addNewFunction(compareFunc, funcCode)
   s"this.$compareFunc($c1, $c2)"
 case schema: StructType =>
+  INPUT_ROW = "i"
   val comparisons = GenerateOrdering.genComparisons(this, schema)
--- End diff --

@kiszk `i` is set to `null` here: 
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala#L498

I'd rather not change this to `INPUT_ROW` since this could potentially make 
things even more confusing. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #13589: [SPARK-15822][SPARK-15825][SQL] Fix SMJ Segfault/...

[kiszk]

Github user kiszk commented on a diff in the pull request:

https://github.com/apache/spark/pull/13589#discussion_r66568805
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
@@ -490,6 +490,7 @@ class CodegenContext {
   addNewFunction(compareFunc, funcCode)
   s"this.$compareFunc($c1, $c2)"
 case schema: StructType =>
+  INPUT_ROW = "i"
   val comparisons = GenerateOrdering.genComparisons(this, schema)
--- End diff --

Is it better to use ```InternalRow $INPUT_ROW = null;``` in an assignment 
for ```funcCode```, to clearly show intention of this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #13589: [SPARK-15822][SPARK-15825][SQL] Fix SMJ Segfault/...

[hvanhovell]

GitHub user hvanhovell opened a pull request:

https://github.com/apache/spark/pull/13589

[SPARK-15822][SPARK-15825][SQL] Fix SMJ Segfault/Invalid results

## What changes were proposed in this pull request?
I'll add desc later


## How was this patch tested?
TBD



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hvanhovell/spark SPARK-15822

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13589.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13589


commit 995c86a09ae7eaf013abb618b65749b1e0f71eca
Author: Herman van Hovell 
Date:   2016-06-10T02:59:31Z

fix input row for comparing struct values




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org