[GitHub] spark pull request #13900: [SPARK-16173][SQL] Can't join describe() of DataF...

2016-06-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13900


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #13900: [SPARK-16173][SQL] Can't join describe() of DataF...

2016-06-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/13900#discussion_r68469199
  
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1908,7 +1908,7 @@ class Dataset[T] private[sql](
 // All columns are string type
 val schema = StructType(
   StructField("summary", StringType) :: outputCols.map(StructField(_, 
StringType))).toAttributes
-LocalRelation.fromExternalRows(schema, ret)
+LocalRelation.fromExternalRows(schema, ret.toArray.toSeq)
--- End diff --

Oh, sure!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #13900: [SPARK-16173][SQL] Can't join describe() of DataF...

2016-06-24 Thread davies
Github user davies commented on a diff in the pull request:

https://github.com/apache/spark/pull/13900#discussion_r68468749
  
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1908,7 +1908,7 @@ class Dataset[T] private[sql](
 // All columns are string type
 val schema = StructType(
   StructField("summary", StringType) :: outputCols.map(StructField(_, 
StringType))).toAttributes
-LocalRelation.fromExternalRows(schema, ret)
+LocalRelation.fromExternalRows(schema, ret.toArray.toSeq)
--- End diff --

Could you add a comment here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #13900: [SPARK-16173][SQL] Can't join describe() of DataF...

2016-06-24 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request:

https://github.com/apache/spark/pull/13900

[SPARK-16173][SQL] Can't join describe() of DataFrame in Scala 2.10

## What changes were proposed in this pull request?

This PR fixes `DataFrame.describe()` by forcing materialization to make the 
`Seq` serializable. Currently, `describe()` of DataFrame throws `Task not 
serializable` Spark exceptions when joining in Scala 2.10.

## How was this patch tested?

Manual. (After building with Scala 2.10, test on `bin/spark-shell` and 
`bin/pyspark`.)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dongjoon-hyun/spark SPARK-16173

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13900.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13900






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org