[GitHub] spark pull request #14108: [SPARK-16453] [BUILD] release-build.sh is missing...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14108: [SPARK-16453] [BUILD] release-build.sh is missing...
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14108#discussion_r70144675 --- Diff: dev/create-release/release-build.sh --- @@ -258,7 +258,7 @@ if [[ "$1" == "publish-snapshot" ]]; then -Phive-thriftserver deploy ./dev/change-scala-version.sh 2.10 $MVN -DzincPort=$ZINC_PORT -Dscala-2.10 --settings $tmp_settings \ --DskipTests $PUBLISH_PROFILES clean deploy +-DskipTests $PUBLISH_PROFILES -Phive-thriftserver clean deploy --- End diff -- Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14108: [SPARK-16453] [BUILD] release-build.sh is missing...
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14108#discussion_r70144693 --- Diff: dev/create-release/release-build.sh --- @@ -258,7 +258,7 @@ if [[ "$1" == "publish-snapshot" ]]; then -Phive-thriftserver deploy ./dev/change-scala-version.sh 2.10 $MVN -DzincPort=$ZINC_PORT -Dscala-2.10 --settings $tmp_settings \ --DskipTests $PUBLISH_PROFILES clean deploy +-DskipTests $PUBLISH_PROFILES -Phive-thriftserver clean deploy --- End diff -- ah missed line 258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14108: [SPARK-16453] [BUILD] release-build.sh is missing...
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14108#discussion_r70144390 --- Diff: dev/create-release/release-build.sh --- @@ -258,7 +258,7 @@ if [[ "$1" == "publish-snapshot" ]]; then -Phive-thriftserver deploy ./dev/change-scala-version.sh 2.10 $MVN -DzincPort=$ZINC_PORT -Dscala-2.10 --settings $tmp_settings \ --DskipTests $PUBLISH_PROFILES clean deploy +-DskipTests $PUBLISH_PROFILES -Phive-thriftserver clean deploy --- End diff -- ah right. Let me move it to there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14108: [SPARK-16453] [BUILD] release-build.sh is missing...
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14108#discussion_r70144266 --- Diff: dev/create-release/release-build.sh --- @@ -258,7 +258,7 @@ if [[ "$1" == "publish-snapshot" ]]; then -Phive-thriftserver deploy ./dev/change-scala-version.sh 2.10 $MVN -DzincPort=$ZINC_PORT -Dscala-2.10 --settings $tmp_settings \ --DskipTests $PUBLISH_PROFILES clean deploy +-DskipTests $PUBLISH_PROFILES -Phive-thriftserver clean deploy --- End diff -- +1. I think the only reason that it wasn't there to begin with was because Scala 2.11 didn't always support the Hive ThriftServer. Let's move it there and also update line 258. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14108: [SPARK-16453] [BUILD] release-build.sh is missing...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14108#discussion_r70144037 --- Diff: dev/create-release/release-build.sh --- @@ -258,7 +258,7 @@ if [[ "$1" == "publish-snapshot" ]]; then -Phive-thriftserver deploy ./dev/change-scala-version.sh 2.10 $MVN -DzincPort=$ZINC_PORT -Dscala-2.10 --settings $tmp_settings \ --DskipTests $PUBLISH_PROFILES clean deploy +-DskipTests $PUBLISH_PROFILES -Phive-thriftserver clean deploy --- End diff -- Shouldn't this be in PUBLISH_PROFILES? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14108: [SPARK-16453] [BUILD] release-build.sh is missing...
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/14108 [SPARK-16453] [BUILD] release-build.sh is missing hive-thriftserver for scala 2.10 ## What changes were proposed in this pull request? This PR adds hive-thriftserver profile to scala 2.10 build created by release-build.sh. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yhuai/spark SPARK-16453 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/14108.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14108 commit 5327a5b14025c463c8d7690dd0e32a3489cb5cc7 Author: Yin Huai Date: 2016-07-08T21:28:22Z [SPARK-16453] [BUILD] release-build.sh is missing hive-thriftserver for scala 2.10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
