GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/14147
[SPARK-14812][ML][MLLIB][PYTHON] Experimental, DeveloperApi annotation
audit for ML
## What changes were proposed in this pull request?
General decisions to follow, except where noted:
* spark.mllib, pyspark.mllib: Remove all Experimental annotations. Leave
DeveloperApi annotations alone.
* spark.ml, pyspark.ml
** Annotate Estimator-Model pairs of classes and companion objects the same
way.
** For all algorithms marked Experimental with Since tag <= 1.6, remove
Experimental annotation.
** For all algorithms marked Experimental with Since tag = 2.0, leave
Experimental annotation.
* DeveloperApi annotations are left alone, except where noted.
* No changes to which types are sealed.
Exceptions where I am leaving items Experimental in spark.ml, pyspark.ml,
mainly because the items are new:
* Model Summary classes
* MLWriter, MLReader, MLWritable, MLReadable
* Evaluator and subclasses: There is discussion of changes around
evaluating multiple metrics at once for efficiency.
* RFormula: Its behavior may need to change slightly to match R in edge
cases.
* AFTSurvivalRegression
* MultilayerPerceptronClassifier
DeveloperApi changes:
* ml.tree.Node, ml.tree.Split, and subclasses should no longer be
DeveloperApi
## How was this patch tested?
N/A
Note to reviewers:
* spark.ml.clustering.LDA underwent significant changes (additional
methods), so let me know if you want me to leave it Experimental.
* Be careful to check for cases where a class should no longer be
Experimental but has an Experimental method, val, or other feature. I did not
find such cases, but please verify.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkbradley/spark experimental-audit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14147.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14147
commit a8beb430de18db7171badea37f12d365b8006467
Author: Joseph K. Bradley
Date: 2016-07-12T00:39:15Z
Removed Experimental annotations from spark.mllib, pyspark.mllib
commit f86ea5aaf15523c944582a56b93fc3b1ee3b58a0
Author: Joseph K. Bradley
Date: 2016-07-12T01:33:56Z
Audited Experimental, DeveloperApi annotations in .ml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org