[GitHub] spark pull request #14203: [SPARK-16546][SQL][PySpark] update python datafra...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14203: [SPARK-16546][SQL][PySpark] update python datafra...
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14203#discussion_r70913944 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1416,13 +1416,25 @@ def drop(self, col): >>> df.join(df2, df.name == df2.name, 'inner').drop(df2.name).collect() [Row(age=5, name=u'Bob', height=85)] + +>>> df.join(df2, df.name == df2.name, 'inner').drop(df2.name) \\ --- End diff -- @rxin Now I update the testcase to make it clearer. Thanks~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14203: [SPARK-16546][SQL][PySpark] update python datafra...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14203#discussion_r70844735 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1416,13 +1416,25 @@ def drop(self, col): >>> df.join(df2, df.name == df2.name, 'inner').drop(df2.name).collect() [Row(age=5, name=u'Bob', height=85)] + +>>> df.join(df2, df.name == df2.name, 'inner').drop(df2.name) \\ --- End diff -- why calling drop twice? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
