[GitHub] spark pull request #14268: [SPARK-16440][MLlib] Destroy broadcasted variable...

2016-07-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/14268


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #14268: [SPARK-16440][MLlib] Destroy broadcasted variable...

2016-07-19 Thread AnthonyTruchet
GitHub user AnthonyTruchet opened a pull request:

https://github.com/apache/spark/pull/14268

[SPARK-16440][MLlib] Destroy broadcasted variables even on driver

## What changes were proposed in this pull request?
Forgotten broadcasted variables were persisted into a previous #PR 14153). 
This PR turns those `unpersist()` into `destroy()` so that memory is freed even 
on the driver.


## How was this patch tested?
Unit Tests in Word2VecSuite were run locally.


This contribution is done on behalf of Criteo, according to the
terms of the Apache license 2.0.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/criteo-forks/spark-1 SPARK-16440

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/14268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14268


commit 4ad38360290d59fdf25a009bc65823553cea9b10
Author: Anthony Truchet 
Date:   2016-07-08T12:54:24Z

[SPARK-16440][MLlib] Destroy broadcasted variables even on driver

This contribution is on done on behalf of Criteo, according to the
terms of the Apache license.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org