[GitHub] spark pull request #14376: [SPARK-16749][SQL] Simplify processing logic in L...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/14376


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #14376: [SPARK-16749][SQL] Simplify processing logic in L...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/14376#discussion_r73959574
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala ---
@@ -565,7 +566,7 @@ private[execution] abstract class WindowFunctionFrame {
 private[execution] final class OffsetWindowFunctionFrame(
 target: MutableRow,
 ordinal: Int,
--- End diff --

Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #14376: [SPARK-16749][SQL] Simplify processing logic in L...

[yhuai]

Github user yhuai commented on a diff in the pull request:

https://github.com/apache/spark/pull/14376#discussion_r73917166
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala ---
@@ -565,7 +566,7 @@ private[execution] abstract class WindowFunctionFrame {
 private[execution] final class OffsetWindowFunctionFrame(
 target: MutableRow,
 ordinal: Int,
--- End diff --

Since we are changing this file, can you add comment to explain what is 
ordinal (with an example)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #14376: [SPARK-16749][SQL] Simplify processing logic in L...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/14376#discussion_r72458927
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala ---
@@ -209,7 +209,7 @@ case class WindowExec(
   new OffsetWindowFunctionFrame(
 target,
 ordinal,
-functions,
+functions.map(_.asInstanceOf[OffsetWindowFunction]),
--- End diff --

leave a comment here about why it is safe to blindly cast?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #14376: [SPARK-16749][SQL] Simplify processing logic in L...

[hvanhovell]

GitHub user hvanhovell opened a pull request:

https://github.com/apache/spark/pull/14376

[SPARK-16749][SQL] Simplify processing logic in LEAD/LAG processing.

## What changes were proposed in this pull request?
The logic for LEAD/LAG processing is more complex that it needs to be. This 
PR fixes that.

## How was this patch tested?
Existing tests.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hvanhovell/spark SPARK-16749

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/14376.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14376


commit 427c179931c1cb05d549ee989e287d7803f20d29
Author: Herman van Hovell 
Date:   2016-07-27T08:55:05Z

Simplify processing logic in offset frame processing.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org