[GitHub] spark pull request #14756: [SPARK-17189][SQL][MINOR] Prefers InternalRow ove...

[clockfly]

Github user clockfly closed the pull request at:

https://github.com/apache/spark/pull/14756


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #14756: [SPARK-17189][SQL][MINOR] Prefers InternalRow ove...

[clockfly]

GitHub user clockfly opened a pull request:

https://github.com/apache/spark/pull/14756

[SPARK-17189][SQL][MINOR] Prefers InternalRow over UnsafeRow if UnsafeRow 
specific interface is not used in AggregationIterator

## What changes were proposed in this pull request?

Minor change to use InternalRow instead of UnsafeRow in method declaration 
of `AggregationIterator.generateResultProjection(...)`, as UnsafeRow specific 
methods are not used.

### Before change:
```
protected def generateResultProjection(): (UnsafeRow, MutableRow) => 
UnsafeRow
```

### After change
```
protected def generateResultProjection(): (InternalRow, MutableRow) => 
UnsafeRow
```

## How was this patch tested?
 
Existing test.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clockfly/spark loose_row_interface

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/14756.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14756


commit d600e681bde23925dedf1261654a34894713f042
Author: Sean Zhong 
Date:   2016-08-22T17:18:05Z

Use a looser interface for InternalRow in result projection




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org