[GitHub] spark pull request #14763: [SPARK-17194] Use single quotes when generating S...

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/14763


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #14763: [SPARK-17194] Use single quotes when generating S...

2016-08-22 Thread JoshRosen
GitHub user JoshRosen opened a pull request:

https://github.com/apache/spark/pull/14763

[SPARK-17194] Use single quotes when generating SQL for string literals

When Spark emits SQL for a string literal, it should wrap the string in 
single quotes, not double quotes. Databases which adhere more strictly to the 
ANSI SQL standards, such as Postgres, allow only single-quotes to be used for 
denoting string literals (see http://stackoverflow.com/a/1992331/590203).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JoshRosen/spark SPARK-17194

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/14763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14763


commit 9076cbeafef8d699562d09b0fea6b0be1eed3535
Author: Josh Rosen 
Date:   2016-08-23T00:39:27Z

[SPARK-17194] Use single quotes when generating SQL for string literals




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org