[GitHub] spark pull request #14816: [SPARK-17245] [SQL] [BRANCH-1.6] Do not rely on H...

[yhuai]

Github user yhuai closed the pull request at:

https://github.com/apache/spark/pull/14816


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #14816: [SPARK-17245] [SQL] [BRANCH-1.6] Do not rely on H...

[yhuai]

GitHub user yhuai opened a pull request:

https://github.com/apache/spark/pull/14816

[SPARK-17245] [SQL] [BRANCH-1.6] Do not rely on Hive's session state to 
retrieve HiveConf

## What changes were proposed in this pull request?
Right now, we rely on Hive's `SessionState.get()` to retrieve the HiveConf 
used by ClientWrapper. However, this conf is actually the HiveConf set with the 
`state`. There is a small chance that we are trying to use the Hive client in a 
new thread while the global client has not been created yet. In this case, 
`SessionState.get()` will return a `null`, which causes a NPE when we call 
`SessionState.get(). getConf `. Since the conf that we want is actually the 
conf we set to `state`. I am changing the code to just call `state.getConf`.

## How was this patch tested?
I will try to figure out how to reproduce the issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yhuai/spark SPARK-17245

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/14816.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14816


commit 8b57886c0489c759f0308a7b104f5b058204cdcd
Author: Yin Huai 
Date:   2016-08-25T21:56:56Z

[SPARK-17245] [SQL] [BRANCH-1.6] Do not rely on Hive's session state to 
retrieve HiveConf




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org