Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14876#discussion_r76900104
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/MergePartialAggregate.scala
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.aggregate
+
+import org.apache.spark.sql.catalyst.expressions.aggregate._
+import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.execution.SparkPlan
+
+object MergePartialAggregate extends Rule[SparkPlan] {
+
+ override def apply(plan: SparkPlan): SparkPlan = plan transform {
+// Normal partial aggregate pair
+case outer @ HashAggregateExec(_, _, _, _, _, _, inner:
HashAggregateExec)
+ if outer.aggregateExpressions.forall(_.mode == Final) &&
+inner.aggregateExpressions.forall(_.mode == Partial) =>
--- End diff --
I think we need to have more strict conditions to make sure these two
operators are for the same group by clause (Although I do not have a case
showing this will break, it is better to list the condition in a more specific
way).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
