[GitHub] spark pull request #15243: Fixing comment since Actor is not used anymore.
Github user danix800 closed the pull request at: https://github.com/apache/spark/pull/15243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15243: Fixing comment since Actor is not used anymore.
Github user danix800 commented on a diff in the pull request: https://github.com/apache/spark/pull/15243#discussion_r80614009 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/WorkerWatcher.scala --- @@ -21,7 +21,7 @@ import org.apache.spark.internal.Logging import org.apache.spark.rpc._ /** - * Actor which connects to a worker process and terminates the JVM if the connection is severed. + * WorkerWatcher RpcEndpoint which connects to a worker process and terminates the JVM if the connection is severed. --- End diff -- Thanks! Fix again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15243: Fixing comment since Actor is not used anymore.
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15243#discussion_r80478992 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/WorkerWatcher.scala --- @@ -21,7 +21,7 @@ import org.apache.spark.internal.Logging import org.apache.spark.rpc._ /** - * Actor which connects to a worker process and terminates the JVM if the connection is severed. + * WorkerWatcher RpcEndpoint which connects to a worker process and terminates the JVM if the connection is severed. --- End diff -- yeah, just say `Endpoint` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15243: Fixing comment since Actor is not used anymore.
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15243#discussion_r80476813 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/WorkerWatcher.scala --- @@ -21,7 +21,7 @@ import org.apache.spark.internal.Logging import org.apache.spark.rpc._ /** - * Actor which connects to a worker process and terminates the JVM if the connection is severed. + * WorkerWatcher RpcEndpoint which connects to a worker process and terminates the JVM if the connection is severed. --- End diff -- The line is too long here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15243: Fixing comment since Actor is not used anymore.
GitHub user danix800 opened a pull request: https://github.com/apache/spark/pull/15243 Fixing comment since Actor is not used anymore. ## What changes were proposed in this pull request? Fixing comment since Actor is not used anymore. You can merge this pull request into a Git repository by running: $ git pull https://github.com/danix800/spark comment-fixing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/15243.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15243 commit 3fe33a29064dcc06e8deebfeec2045af4a44dfed Author: Ding Fei Date: 2016-09-26T13:01:33Z Fixing comment since Actor is not used anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
