[GitHub] spark pull request #15284: [SPARK-17368] [SQL] Add support for value class s...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/15284


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15284: [SPARK-17368] [SQL] Add support for value class s...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/15284#discussion_r83334074
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala 
---
@@ -628,7 +628,7 @@ object ScalaReflection extends ScalaReflection {
   /*
* Retrieves the runtime class corresponding to the provided type.
*/
-  def getClassFromType(tpe: Type): Class[_] = 
mirror.runtimeClass(tpe.erasure.typeSymbol.asClass)
+  def getClassFromType(tpe: Type): Class[_] = 
mirror.runtimeClass(tpe.typeSymbol.asClass)
--- End diff --

this is the main change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15284: [SPARK-17368] [SQL] Add support for value class s...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/15284#discussion_r81025673
  
--- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
 ---
@@ -66,8 +66,6 @@ case class RepeatedData(
 mapFieldNull: scala.collection.Map[Int, java.lang.Long],
 structField: PrimitiveData)
 
-case class SpecificCollection(l: List[Int])
--- End diff --

cleanup: found this unused class whilst going over the code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15284: [SPARK-17368] [SQL] Add support for value class s...

[jodersky]

GitHub user jodersky opened a pull request:

https://github.com/apache/spark/pull/15284

[SPARK-17368] [SQL] Add support for value class serialization and 
deserialization

## What changes were proposed in this pull request?
Value classes were unsupported because catalyst data types were
obtained through reflection on erased types, which would resolve to a
value class' wrapped type and hence lead to unavailable methods during
code generation.

This patch simply removes the erasure step when getting data types for
catalyst.

## How was this patch tested?
Additional tests in `ExpressionEncoderSuite`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jodersky/spark value-classes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15284


commit a3dce9f5f9ced492fa6f20b93497856fd51fc757
Author: Jakob Odersky 
Date:   2016-09-28T21:19:26Z

Add support for value class serialization and deserialization

Value classes were unsupported because catalyst data types were
obtained through reflection on erased types, which would resolve to a
value class' wrapped type and hence lead to unavailable methods during
code generation.

This patch simply removes the erasure step when getting data types for
catalyst.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org