[GitHub] spark pull request #15422: [SPARK-17850][Core]Add a flag to ignore corrupt f...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15422 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15422: [SPARK-17850][Core]Add a flag to ignore corrupt f...
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/15422#discussion_r83093287
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -588,6 +588,12 @@ object SQLConf {
.doubleConf
.createWithDefault(0.05)
+ val IGNORE_CORRUPT_FILES =
SQLConfigBuilder("spark.sql.files.ignoreCorruptFiles")
+.doc("Whether to ignore corrupt files. If true, the Spark jobs will
continue to run when " +
+ "encountering corrupt files and contents that have been read will
still be returned.")
+.booleanConf
+.createWithDefault(false)
+
--- End diff --
A sql conf can appear in the following command:
```
sql("set -v").filter('key contains "files").show(truncate = false)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15422: [SPARK-17850][Core]Add a flag to ignore corrupt f...
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15422#discussion_r82932947
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -588,6 +588,12 @@ object SQLConf {
.doubleConf
.createWithDefault(0.05)
+ val IGNORE_CORRUPT_FILES =
SQLConfigBuilder("spark.sql.files.ignoreCorruptFiles")
+.doc("Whether to ignore corrupt files. If true, the Spark jobs will
continue to run when " +
+ "encountering corrupt files and contents that have been read will
still be returned.")
+.booleanConf
+.createWithDefault(false)
+
--- End diff --
Curious why we are duplicating the parameter in sql namespace. Wont
spark.files.ignoreCorruptFiles not do ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15422: [SPARK-17850][Core]Add a flag to ignore corrupt f...
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15422#discussion_r82933077
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -170,4 +170,9 @@ package object config {
.doc("Port to use for the block managed on the driver.")
.fallbackConf(BLOCK_MANAGER_PORT)
+ private[spark] val IGNORE_CORRUPT_FILES =
ConfigBuilder("spark.files.ignoreCorruptFiles")
+.doc("Whether to ignore corrupt files. If true, the Spark jobs will
continue to run when " +
+ "encountering corrupt files and contents that have been read will
still be returned.")
+.booleanConf
+.createWithDefault(false)
--- End diff --
So either way we will have a behavioral change - if NewHadoopRDD vs
HadoopRDD.
IMO that is fine, given that we are standardizing on the behavior and this
is something which was a corner case anyway.
Setting default to false makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15422: [SPARK-17850][Core]Add a flag to ignore corrupt f...
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15422#discussion_r82932992
--- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala ---
@@ -179,7 +183,16 @@ class NewHadoopRDD[K, V](
override def hasNext: Boolean = {
if (!finished && !havePair) {
- finished = !reader.nextKeyValue
+ try {
+finished = !reader.nextKeyValue
+ } catch {
+case e: IOException =>
+ if (ignoreCorruptFiles) {
+finished = true
+ } else {
+throw e
+ }
+ }
--- End diff --
Thanks for changing this too !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15422: [SPARK-17850][Core]Add a flag to ignore corrupt f...
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15422#discussion_r82932645
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -253,8 +256,12 @@ class HadoopRDD[K, V](
try {
finished = !reader.next(key, value)
} catch {
- case eof: EOFException =>
-finished = true
+ case e: IOException =>
+if (ignoreCorruptFiles) {
+ finished = true
+} else {
+ throw e
+}
--- End diff --
nit: case e: IOException if ignoreCorruptFiles =>
would have been more concise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
