[GitHub] spark pull request #15434: [SPARK-17873][SQL] ALTER TABLE RENAME TO should a...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15434: [SPARK-17873][SQL] ALTER TABLE RENAME TO should a...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15434#discussion_r82944802
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -459,11 +459,20 @@ class SessionCatalog(
* If a database is specified in `oldName`, this will rename the table
in that database.
* If no database is specified, this will first attempt to rename a
temporary table with
* the same name, then, if that does not exist, rename the table in the
current database.
+ *
+ * This assumes the database specified in `newName` matches the one in
`oldName`.
*/
- def renameTable(oldName: TableIdentifier, newName: String): Unit =
synchronized {
+ def renameTable(oldName: TableIdentifier, newName: TableIdentifier):
Unit = synchronized {
val db = formatDatabaseName(oldName.database.getOrElse(currentDb))
+newName.database.map(formatDatabaseName).foreach { newDb =>
--- End diff --
uh, I see. If this is by design, I do not have more questions. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15434: [SPARK-17873][SQL] ALTER TABLE RENAME TO should a...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15434#discussion_r82938529
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -459,11 +459,20 @@ class SessionCatalog(
* If a database is specified in `oldName`, this will rename the table
in that database.
* If no database is specified, this will first attempt to rename a
temporary table with
* the same name, then, if that does not exist, rename the table in the
current database.
+ *
+ * This assumes the database specified in `newName` matches the one in
`oldName`.
*/
- def renameTable(oldName: TableIdentifier, newName: String): Unit =
synchronized {
+ def renameTable(oldName: TableIdentifier, newName: TableIdentifier):
Unit = synchronized {
val db = formatDatabaseName(oldName.database.getOrElse(currentDb))
+newName.database.map(formatDatabaseName).foreach { newDb =>
--- End diff --
see PR description, we should use the database of source table, so that
users can just write `db.tbl1 RENAME TO tbl2`. This is different from Hive, as
we don't support move table from one database to another.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15434: [SPARK-17873][SQL] ALTER TABLE RENAME TO should a...
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/15434 [SPARK-17873][SQL] ALTER TABLE RENAME TO should allow users to specify database in destination table name ## What changes were proposed in this pull request? In #14955 , we forbid users to specify database of destination table in ALTER TABLE RENAME TO, to be consistent with other database systems and also make it easier to rename tables in non-current database, e.g. users can write `ALTER TABLE db1.tbl RENAME TO tbl2`, instead of `ALTER TABLE db1.tbl RENAME TO db1.tbl2`. However, this is a breaking change. Users may already have queries that specify database of destination table in ALTER TABLE RENAME TO. This PR reverts most of #14955 , and simplify the usage of ALTER TABLE RENAME TO by making database of source table the default database of destination table, instead of current database, so that users can still write `ALTER TABLE db1.tbl RENAME TO tbl2`. ## How was this patch tested? The added back tests and some new tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan/spark revert Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/15434.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15434 commit d14c8629b8815dd2a8aa5ed720d699b235c54be0 Author: Wenchen Fan Date: 2016-10-11T08:47:37Z temp commit 393dc6542bb207f812a4af57211ad5e2a3a94dc5 Author: Wenchen Fan Date: 2016-10-11T14:29:35Z fix RENAME TO --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
