[GitHub] spark pull request #15453: [SPARK-17770] [CATALYST] making ObjectType public

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/15453


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15453: [SPARK-17770] [CATALYST] making ObjectType public

[bdrillard]

Github user bdrillard commented on a diff in the pull request:

https://github.com/apache/spark/pull/15453#discussion_r83343796
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/ObjectType.scala ---
@@ -19,7 +19,7 @@ package org.apache.spark.sql.types
 
 import scala.language.existentials
 
-private[sql] object ObjectType extends AbstractDataType {
+object ObjectType extends AbstractDataType {
--- End diff --

Sure, I've updated the pull-request for the annotation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15453: [SPARK-17770] [CATALYST] making ObjectType public

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/15453#discussion_r83114377
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/ObjectType.scala ---
@@ -19,7 +19,7 @@ package org.apache.spark.sql.types
 
 import scala.language.existentials
 
-private[sql] object ObjectType extends AbstractDataType {
+object ObjectType extends AbstractDataType {
--- End diff --

I would put a InterfaceStability.Evolving to this.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15453: [SPARK-17770] [CATALYST] making ObjectType public

[bdrillard]

GitHub user bdrillard opened a pull request:

https://github.com/apache/spark/pull/15453

[SPARK-17770] [CATALYST] making ObjectType public

## What changes were proposed in this pull request?

In order to facilitate the writing of additional Encoders, I proposed 
opening up the ObjectType SQL DataType. This DataType is used extensively in 
the JavaBean Encoder, but would also be useful in writing other custom 
encoders. 

As mentioned by @marmbrus, it is understood that the Expressions API is 
subject to potential change.

## How was this patch tested?

The change only affects the visibility of the ObjectType class, and the 
existing SQL test suite still runs without error.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bdrillard/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15453


commit 173dceda3da45bb0bd0b578f70ae97143424a727
Author: ALeksander Eskilson 
Date:   2016-10-12T20:19:53Z

[SPARK-17770] making ObjectType public




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org