[GitHub] spark pull request #15829: [SPARK-18379][SQL] Make the parallelism of parall...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/15829


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15829: [SPARK-18379][SQL] Make the parallelism of parall...

[yhuai]

Github user yhuai commented on a diff in the pull request:

https://github.com/apache/spark/pull/15829#discussion_r87253993
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -396,6 +396,13 @@ object SQLConf {
   .intConf
   .createWithDefault(32)
 
+  val PARALLEL_PARTITION_DISCOVERY_PARALLELISM =
+
SQLConfigBuilder("spark.sql.sources.parallelPartitionDiscovery.parallelism")
+  .doc("The number of parallelism to list a collection of path 
recursively, Set the " +
+"number to prevent file listing from generating too many tasks.")
+  .intConf
+  .createWithDefault(100)
--- End diff --

btw, I think 100 is too small.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15829: [SPARK-18379][SQL] Make the parallelism of parall...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/15829#discussion_r87244612
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -396,6 +396,13 @@ object SQLConf {
   .intConf
   .createWithDefault(32)
 
+  val PARALLEL_PARTITION_DISCOVERY_PARALLELISM =
+
SQLConfigBuilder("spark.sql.sources.parallelPartitionDiscovery.parallelism")
+  .doc("The number of parallelism to list a collection of path 
recursively, Set the " +
+"number to prevent file listing from generating too many tasks.")
+  .intConf
+  .createWithDefault(100)
--- End diff --

cc @liancheng @yhuai 

This should be an internal config.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15829: [SPARK-18379][SQL] Make the parallelism of parall...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/15829#discussion_r87239264
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -396,6 +396,13 @@ object SQLConf {
   .intConf
   .createWithDefault(32)
 
+  val PARALLEL_PARTITION_DISCOVERY_PARALLELISM =
+
SQLConfigBuilder("spark.sql.sources.parallelPartitionDiscovery.parallelism")
+  .doc("The number of parallelism to list a collection of path 
recursively, Set the " +
+"number to prevent file listing from generating too many tasks.")
+  .intConf
+  .createWithDefault(100)
--- End diff --

Should this be internal()? although I tend to agree with your logic, I'd 
also love to see if the person who made it 1 has thoughts. I can't figure 
out where it came from via git blame though after several code refactorings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15829: [SPARK-18379][SQL] Make the parallelism of parall...

[uncleGen]

GitHub user uncleGen opened a pull request:

https://github.com/apache/spark/pull/15829

[SPARK-18379][SQL] Make the parallelism of parallelPartitionDiscovery 
configurable.

## What changes were proposed in this pull request?

The largest parallelism in PartitioningAwareFileIndex 
#listLeafFilesInParallel() is 1 in hard code. We may need to make this 
number configurable. And in PR, I reduce it to 100.

## How was this patch tested?

Existing ut.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/uncleGen/spark SPARK-18379

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15829.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15829


commit 112f9d163208ae856d156c13901f438cf026cdda
Author: genmao.ygm 
Date:   2016-11-09T11:09:20Z

SPARK-18379: Make the parallelism of parallelPartitionDiscovery 
configurable.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org