[GitHub] spark pull request #16444: [Minor][Doc] Minor doc change for YARN credential...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16444: [Minor][Doc] Minor doc change for YARN credential...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16444#discussion_r94283097
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala
---
@@ -38,6 +38,8 @@ import org.apache.spark.util.Utils
*
* Also each credential provider is controlled by
* spark.yarn.security.credentials.{service}.enabled, it will not be
loaded in if set to false.
+ * E.g., hive's credential provider [[HiveCredentialProvider]] can be
enable/disable by
--- End diff --
Fixed. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16444: [Minor][Doc] Minor doc change for YARN credential...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16444#discussion_r94282644
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala
---
@@ -38,6 +38,8 @@ import org.apache.spark.util.Utils
*
* Also each credential provider is controlled by
* spark.yarn.security.credentials.{service}.enabled, it will not be
loaded in if set to false.
+ * E.g., hive's credential provider [[HiveCredentialProvider]] can be
enable/disable by
--- End diff --
Nit: "For example, Hive's ..." and "can be enabled/disabled"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16444: [Minor][Doc] Minor doc change for YARN credential...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/16444
[Minor][Doc] Minor doc change for YARN credential providers
## What changes were proposed in this pull request?
The configuration `spark.yarn.security.tokens.{service}.enabled` is
deprecated. Now we should use
`spark.yarn.security.credentials.{service}.enabled`. Some places in the doc is
not updated yet.
## How was this patch tested?
N/A. Just doc change.
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 minor-credential-provider-doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16444
commit f89a31a2e7bab8c6a32e1e0baaadaf6abf7d9c4d
Author: Liang-Chi Hsieh
Date: 2016-12-31T14:16:26Z
Minor doc change for credential providers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
