[GitHub] spark pull request #16753: [SPARK-19296][SQL] Deduplicate url and table in J...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16753 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16753: [SPARK-19296][SQL] Deduplicate url and table in J...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16753#discussion_r98835277
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -53,33 +53,31 @@ class JdbcRelationProvider extends
CreatableRelationProvider
parameters: Map[String, String],
df: DataFrame): BaseRelation = {
val jdbcOptions = new JDBCOptions(parameters)
-val url = jdbcOptions.url
val table = jdbcOptions.table
-val createTableOptions = jdbcOptions.createTableOptions
val isTruncate = jdbcOptions.isTruncate
--- End diff --
The same here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16753: [SPARK-19296][SQL] Deduplicate url and table in J...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16753#discussion_r98835197
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -53,33 +53,31 @@ class JdbcRelationProvider extends
CreatableRelationProvider
parameters: Map[String, String],
df: DataFrame): BaseRelation = {
val jdbcOptions = new JDBCOptions(parameters)
-val url = jdbcOptions.url
val table = jdbcOptions.table
--- End diff --
Maybe, we do not need this too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
