[GitHub] spark pull request #16787: [WIP][SPARK-19448][SQL]optimize some duplication ...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99585445
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -276,4 +276,4 @@ private[hive] object HiveShim {
compressType = intermediateCompressType
}
}
-}
+}
--- End diff --
Please add a new line here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16787: [WIP][SPARK-19448][SQL]optimize some duplication ...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99585644
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -841,5 +841,6 @@ private[client] class Shim_v1_2 extends Shim_v1_1 {
case e: InvocationTargetException => throw e.getCause()
}
}
-
+
--- End diff --
Please remove this empty spaces?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16787: [WIP][SPARK-19448][SQL]optimize some duplication ...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99585661
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -841,5 +841,6 @@ private[client] class Shim_v1_2 extends Shim_v1_1 {
case e: InvocationTargetException => throw e.getCause()
}
}
-
+
}
+
--- End diff --
This empty line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16787: [WIP][SPARK-19448][SQL]optimize some duplication ...
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r99588025
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -841,5 +841,6 @@ private[client] class Shim_v1_2 extends Shim_v1_1 {
case e: InvocationTargetException => throw e.getCause()
}
}
-
+
}
+
--- End diff --
yes... I make a mistake, there is another HiveShim.scala .
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
