[GitHub] spark pull request #16800: [SPARK-19456][SparkR][WIP]:Add LinearSVC R API

[wangmiao1981]

Github user wangmiao1981 commented on a diff in the pull request:

https://github.com/apache/spark/pull/16800#discussion_r99755781
  
--- Diff: R/pkg/R/generics.R ---
@@ -1376,6 +1376,10 @@ setGeneric("spark.kstest", function(data, ...) { 
standardGeneric("spark.kstest")
 #' @export
 setGeneric("spark.lda", function(data, ...) { standardGeneric("spark.lda") 
})
 
+#' @rdname spark.linearSvc
+#' @export
+setGeneric("spark.linearSvc", function(data, formula, ...) { 
standardGeneric("spark.linearSvc") })
--- End diff --

`svmLinear` looks fine. I will change the files tomorrow. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16800: [SPARK-19456][SparkR][WIP]:Add LinearSVC R API

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/16800#discussion_r99477755
  
--- Diff: R/pkg/R/generics.R ---
@@ -1376,6 +1376,10 @@ setGeneric("spark.kstest", function(data, ...) { 
standardGeneric("spark.kstest")
 #' @export
 setGeneric("spark.lda", function(data, ...) { standardGeneric("spark.lda") 
})
 
+#' @rdname spark.linearSvc
+#' @export
+setGeneric("spark.linearSvc", function(data, formula, ...) { 
standardGeneric("spark.linearSvc") })
--- End diff --

maybe `svmLinear`? http://topepo.github.io/caret/available-models.html



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16800: [SPARK-19456][SparkR][WIP]:Add LinearSVC R API

[wangmiao1981]

Github user wangmiao1981 commented on a diff in the pull request:

https://github.com/apache/spark/pull/16800#discussion_r99474739
  
--- Diff: R/pkg/R/generics.R ---
@@ -1376,6 +1376,10 @@ setGeneric("spark.kstest", function(data, ...) { 
standardGeneric("spark.kstest")
 #' @export
 setGeneric("spark.lda", function(data, ...) { standardGeneric("spark.lda") 
})
 
+#' @rdname spark.linearSvc
+#' @export
+setGeneric("spark.linearSvc", function(data, formula, ...) { 
standardGeneric("spark.linearSvc") })
--- End diff --

svm with linear kernel in glmnet package has the same functionality as this 
one. But they support other kernels. `linearSvm` is better than `linearSvc` (c 
denotes classifier)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16800: [SPARK-19456][SparkR][WIP]:Add LinearSVC R API

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/16800#discussion_r99462444
  
--- Diff: R/pkg/R/generics.R ---
@@ -1376,6 +1376,10 @@ setGeneric("spark.kstest", function(data, ...) { 
standardGeneric("spark.kstest")
 #' @export
 setGeneric("spark.lda", function(data, ...) { standardGeneric("spark.lda") 
})
 
+#' @rdname spark.linearSvc
+#' @export
+setGeneric("spark.linearSvc", function(data, formula, ...) { 
standardGeneric("spark.linearSvc") })
--- End diff --

any name more R familiar that could be more fitting here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16800: [SPARK-19456][SparkR][WIP]:Add LinearSVC R API

[wangmiao1981]

GitHub user wangmiao1981 opened a pull request:

https://github.com/apache/spark/pull/16800

[SPARK-19456][SparkR][WIP]:Add LinearSVC R API

## What changes were proposed in this pull request?

Linear SVM classifier is newly added into ML and python API has been added. 
This JIRA is to add R side API.

Marked as WIP, as I am designing unit tests.

## How was this patch tested?

Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wangmiao1981/spark svc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/16800.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16800


commit 90b5203d0048879108f6b637ec182f2ef29e769b
Author: wm...@hotmail.com 
Date:   2017-02-03T22:03:12Z

initial check in

commit a4dceec9debb14eae5c7040c58dd7988aa9a67c5
Author: wm...@hotmail.com 
Date:   2017-02-04T01:21:07Z

start test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org