[GitHub] spark pull request #17486: [SPARK-20164][SQL] AnalysisException not tolerant...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17486 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17486: [SPARK-20164][SQL] AnalysisException not tolerant...
Github user kunalkhamar commented on a diff in the pull request:
https://github.com/apache/spark/pull/17486#discussion_r109081024
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala ---
@@ -43,7 +43,7 @@ class AnalysisException protected[sql] (
}
override def getMessage: String = {
-val planAnnotation = plan.map(p => s";\n$p").getOrElse("")
+val planAnnotation = Option(plan).map(p => s";\n$p").getOrElse("")
--- End diff --
Right, updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17486: [SPARK-20164][SQL] AnalysisException not tolerant...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17486#discussion_r109079424
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala ---
@@ -43,7 +43,7 @@ class AnalysisException protected[sql] (
}
override def getMessage: String = {
-val planAnnotation = plan.map(p => s";\n$p").getOrElse("")
+val planAnnotation = Option(plan).map(p => s";\n$p").getOrElse("")
--- End diff --
Sorry, my fault. We need another `flatten`.
```Scala
val planAnnotation = Option(plan).flatten.map(p =>
s";\n$p").getOrElse("")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17486: [SPARK-20164][SQL] AnalysisException not tolerant...
Github user kunalkhamar commented on a diff in the pull request:
https://github.com/apache/spark/pull/17486#discussion_r109057059
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala ---
@@ -43,7 +43,7 @@ class AnalysisException protected[sql] (
}
override def getMessage: String = {
-val planAnnotation = plan.map(p => s";\n$p").getOrElse("")
+val planAnnotation = if (plan == null) "" else plan.map(p =>
s";\n$p").getOrElse("")
--- End diff --
Changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17486: [SPARK-20164][SQL] AnalysisException not tolerant...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17486#discussion_r109049522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala ---
@@ -43,7 +43,7 @@ class AnalysisException protected[sql] (
}
override def getMessage: String = {
-val planAnnotation = plan.map(p => s";\n$p").getOrElse("")
+val planAnnotation = if (plan == null) "" else plan.map(p =>
s";\n$p").getOrElse("")
--- End diff --
Nit:
```Scala
val planAnnotation = Option(plan).map(p => s";\n$p").getOrElse("")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
