[GitHub] spark pull request #18126: [SPARK-20843][Core]Add a config to set driver ter...

2017-05-26 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18126


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18126: [SPARK-20843][Core]Add a config to set driver ter...

2017-05-26 Thread zsxwing 
Github user zsxwing commented on a diff in the pull request:

https://github.com/apache/spark/pull/18126#discussion_r118805346
  
--- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -57,7 +57,8 @@ private[deploy] class DriverRunner(
   @volatile private[worker] var finalException: Option[Exception] = None
 
   // Timeout to wait for when trying to terminate a driver.
-  private val DRIVER_TERMINATE_TIMEOUT_MS = 10 * 1000
+  private val DRIVER_TERMINATE_TIMEOUT_MS =
+conf.getTimeAsMs("spark.worker.driverTerminateTimeout", "10s")
--- End diff --

`spark.worker` means this is only for Spark workers, so I think it should 
be obvious. Do you have a better config name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18126: [SPARK-20843][Core]Add a config to set driver ter...

2017-05-26 Thread BryanCutler 
Github user BryanCutler commented on a diff in the pull request:

https://github.com/apache/spark/pull/18126#discussion_r118803788
  
--- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -57,7 +57,8 @@ private[deploy] class DriverRunner(
   @volatile private[worker] var finalException: Option[Exception] = None
 
   // Timeout to wait for when trying to terminate a driver.
-  private val DRIVER_TERMINATE_TIMEOUT_MS = 10 * 1000
+  private val DRIVER_TERMINATE_TIMEOUT_MS =
+conf.getTimeAsMs("spark.worker.driverTerminateTimeout", "10s")
--- End diff --

Just wondering if maybe adding something to the property to be clear that 
this is for a driver with deploy mode cluster only?  Although it is prefixed 
with `worker` so maybe that is good enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18126: [SPARK-20843][Core]Add a config to set driver ter...

2017-05-26 Thread zsxwing 
GitHub user zsxwing opened a pull request:

https://github.com/apache/spark/pull/18126

[SPARK-20843][Core]Add a config to set driver terminate timeout

## What changes were proposed in this pull request?

Add a worker configuration to set how long to wait before force killing 
driver.
 
## How was this patch tested?

Jenkins

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zsxwing/spark SPARK-20843

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18126


commit ca2c9c53040373e82ff350c1b3c77c1512926cec
Author: Shixiong Zhu 
Date:   2017-05-26T21:20:08Z

Add a config to set driver terminate timeout




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org