[GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18129#discussion_r119620209
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
---
@@ -122,6 +122,7 @@ class ClientSuite extends SparkFunSuite with Matchers
with BeforeAndAfterAll
cp should not contain (uri.getPath())
}
})
+cp should not contain "local"
--- End diff --
Can you please add parentheses here `("local")`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18129#discussion_r119412348
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
---
@@ -119,12 +119,13 @@ class ClientSuite extends SparkFunSuite with Matchers
with BeforeAndAfterAll
if (LOCAL_SCHEME.equals(uri.getScheme())) {
cp should contain (uri.getPath())
} else {
-cp should not contain (uri.getPath())
+cp should not contain uri.getPath()
--- End diff --
Could you avoid these noisy changes and also keep the existing style of
using parentheses in the code you're actually adding?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...
Github user liyichao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18129#discussion_r119309080
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
---
@@ -116,15 +116,16 @@ class ClientSuite extends SparkFunSuite with Matchers
with BeforeAndAfterAll
val cp = env("CLASSPATH").split(":|;|")
s"$SPARK,$USER,$ADDED".split(",").foreach({ entry =>
val uri = new URI(entry)
- if (LOCAL_SCHEME.equals(uri.getScheme())) {
-cp should contain (uri.getPath())
+ if (LOCAL_SCHEME.equals(uri.getScheme)) {
+cp should contain (uri.getPath)
--- End diff --
It is Intellij that advises the above changes. I will revert them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18129#discussion_r119277116
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
---
@@ -116,15 +116,16 @@ class ClientSuite extends SparkFunSuite with Matchers
with BeforeAndAfterAll
val cp = env("CLASSPATH").split(":|;|")
s"$SPARK,$USER,$ADDED".split(",").foreach({ entry =>
val uri = new URI(entry)
- if (LOCAL_SCHEME.equals(uri.getScheme())) {
-cp should contain (uri.getPath())
+ if (LOCAL_SCHEME.equals(uri.getScheme)) {
+cp should contain (uri.getPath)
--- End diff --
Maybe it is not so necessary to change the previous style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
