[GitHub] spark pull request #18367: [SQL][Doc] Fix documentation of lpad
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18367 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18367: [SQL][Doc] Fix documentation of lpad
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18367#discussion_r123265927
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2350,7 +2350,7 @@ object functions {
def unbase64(e: Column): Column = withExpr { UnBase64(e.expr) }
/**
- * Right-padded with pad to a length of len.
+ * Right-pad the string column with pad to a length of len.
--- End diff --
While here, let's make the description more complete in both cases, and
consistent with the SQL usage doc:
```
_FUNC_(str, len, pad) - Returns `str`, right-padded with `pad` to a
length of `len`.
If `str` is longer than `len`, the return value is shortened to `len`
characters.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18367: [SQL][Doc] Fix documentation of lpad
GitHub user actuaryzhang opened a pull request: https://github.com/apache/spark/pull/18367 [SQL][Doc] Fix documentation of lpad ## What changes were proposed in this pull request? Fix incomplete documentation for `lpad`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/actuaryzhang/spark SQLDoc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/18367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18367 commit 42df330527663456a698f493ac611025f89e6d45 Author: actuaryzhang Date: 2017-06-20T19:05:45Z fix doc of lpad --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
