[GitHub] spark pull request #18373: [SPARK-20431][SS][FOLLOWUP] Specify a schema by u...

2017-06-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18373


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #18373: [SPARK-20431][SS][FOLLOWUP] Specify a schema by u...

2017-06-20 Thread maropu
Github user maropu commented on a diff in the pull request:

https://github.com/apache/spark/pull/18373#discussion_r123150122
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala
 ---
@@ -663,4 +663,16 @@ class DataStreamReaderWriterSuite extends StreamTest 
with BeforeAndAfter {
 }
 assert(fs.exists(checkpointDir))
   }
+
+  test("SPARK-20431: Specify a schema by using a DDL-formatted string") {
+spark.readStream
+  .format("org.apache.spark.sql.streaming.test")
+  .schema("aa integer")
--- End diff --

Nit: Capitalize `integer`? (I remember @gatorsmile suggested before)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org