[GitHub] spark pull request #18397: [SPARK-21159][core] Don't try to connect to launc...

2017-06-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18397


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #18397: [SPARK-21159][core] Don't try to connect to launc...

2017-06-22 Thread vanzin
GitHub user vanzin opened a pull request:

https://github.com/apache/spark/pull/18397

[SPARK-21159][core] Don't try to connect to launcher in standalone cluster 
mode.

Monitoring for standalone cluster mode is not implemented (see 
SPARK-11033), but
the same scheduler implementation is used, and if it tries to connect to the
launcher it will fail. So fix the scheduler so it only tries that in client 
mode;
cluster mode applications will be correctly launched and will work, but 
monitoring
through the launcher handle will not be available.

Tested by running a cluster mode app with "SparkLauncher.startApplication".

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vanzin/spark SPARK-21159

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18397.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18397


commit b7da07deffd39a77f6320b7dd7440120272553f9
Author: Marcelo Vanzin 
Date:   2017-06-22T23:50:31Z

[SPARK-21159][core] Don't try to connect to launcher in standalone cluster 
mode.

Monitoring for standalone cluster mode is not implemented (see 
SPARK-11033), but
the same scheduler implementation is used, and if it tries to connect to the
launcher it will fail. So fix the scheduler so it only tries that in client 
mode;
cluster mode applications will be correctly launched and will work, but 
monitoring
through the launcher handle will not be available.

Tested by running a cluster mode app with "SparkLauncher.startApplication".




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org