[GitHub] spark pull request #18689: [SPARK-10063] Follow-up: remove dead code related...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/18689#discussion_r128623337
  
--- Diff: 
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
@@ -139,19 +139,10 @@ object FileCommitProtocol {
   /**
* Instantiates a FileCommitProtocol using the given className.
*/
-  def instantiate(className: String, jobId: String, outputPath: String, 
isAppend: Boolean)
+  def instantiate(className: String, jobId: String, outputPath: String)
--- End diff --

If anybody in open source community needs it, please let us know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18689: [SPARK-10063] Follow-up: remove dead code related...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18689


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18689: [SPARK-10063] Follow-up: remove dead code related...

[cloud-fan]

GitHub user cloud-fan opened a pull request:

https://github.com/apache/spark/pull/18689

[SPARK-10063] Follow-up: remove dead code related to an old output committer

## What changes were proposed in this pull request?

DirectParquetOutputCommitter was removed from Spark as it was deemed unsafe 
to use. We however still have some code to generate warning. This patch removes 
those code as well.

This is kind of a follow-up of https://github.com/apache/spark/pull/16796

## How was this patch tested?

existing tests

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloud-fan/spark minor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18689


commit 38ef37ba6178a59d58b8392ac26a69ec39907996
Author: Wenchen Fan 
Date:   2017-07-19T15:04:02Z

remove dead code related to an old output committer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org