[GitHub] spark pull request #19008: [SPARK-21756][SQL]Add JSON option to allow unquot...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/19008


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19008: [SPARK-21756][SQL]Add JSON option to allow unquot...

[vinodkc]

Github user vinodkc commented on a diff in the pull request:

https://github.com/apache/spark/pull/19008#discussion_r134227248
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonParsingOptionsSuite.scala
 ---
@@ -72,6 +72,21 @@ class JsonParsingOptionsSuite extends QueryTest with 
SharedSQLContext {
 assert(df.first().getString(0) == "Reynold Xin")
   }
 
+  test("allowUnquotedControlChars off") {
+val str = """{"name" : " + "a\tb"}"""
--- End diff --

Updated the the test case. Thanks for the review comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19008: [SPARK-21756][SQL]Add JSON option to allow unquot...

[vinodkc]

Github user vinodkc commented on a diff in the pull request:

https://github.com/apache/spark/pull/19008#discussion_r134227247
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonParsingOptionsSuite.scala
 ---
@@ -72,6 +72,21 @@ class JsonParsingOptionsSuite extends QueryTest with 
SharedSQLContext {
 assert(df.first().getString(0) == "Reynold Xin")
   }
 
+  test("allowUnquotedControlChars off") {
+val str = """{"name" : " + "a\tb"}"""
--- End diff --

Update the the test case. Thanks for the review comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19008: [SPARK-21756][SQL]Add JSON option to allow unquot...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/19008#discussion_r134128223
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonParsingOptionsSuite.scala
 ---
@@ -72,6 +72,21 @@ class JsonParsingOptionsSuite extends QueryTest with 
SharedSQLContext {
 assert(df.first().getString(0) == "Reynold Xin")
   }
 
+  test("allowUnquotedControlChars off") {
+val str = """{"name" : " + "a\tb"}"""
--- End diff --

This is corrupted, right? It is different from the string used in the 
following test case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19008: [SPARK-21756][SQL]Add JSON option to allow unquot...

[vinodkc]

GitHub user vinodkc opened a pull request:

https://github.com/apache/spark/pull/19008

[SPARK-21756][SQL]Add JSON option to allow unquoted control characters

## What changes were proposed in this pull request?

This patch adds allowUnquotedControlChars option in JSON data source to 
allow JSON Strings to contain unquoted control characters (ASCII characters 
with value less than 32, including tab and line feed characters)

## How was this patch tested?
Add new test cases



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vinodkc/spark br_fix_SPARK-21756

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/19008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19008


commit 6f009579687e11f34b26bb2f21883377b88f5b35
Author: vinodkc 
Date:   2017-08-20T17:39:27Z

Add JSON option to allow unquoted control characters




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org