[GitHub] spark pull request #19072: [SPARK-17139][ML][FOLLOW-UP] Add convenient metho...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19072 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19072: [SPARK-17139][ML][FOLLOW-UP] Add convenient metho...
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19072#discussion_r136470877
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1473,6 +1473,17 @@ sealed trait LogisticRegressionSummary extends
Serializable {
/** Returns weighted averaged f1-measure. */
@Since("2.3.0")
def weightedFMeasure: Double = multiclassMetrics.weightedFMeasure(1.0)
+
+ /**
+ * Convenient method for casting to binary logistic regression summary.
+ * This method will throws an Exception if the summary is not a binary
summary.
--- End diff --
For future reference & being careful: This didn't correct "throws" ->
"throw" but I'll just go ahead and merge this since it's a tiny nit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19072: [SPARK-17139][ML][FOLLOW-UP] Add convenient metho...
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19072#discussion_r136249376
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1471,6 +1471,17 @@ sealed trait LogisticRegressionSummary extends
Serializable {
/** Returns weighted averaged f1-measure. */
@Since("2.3.0")
def weightedFMeasure: Double = multiclassMetrics.weightedFMeasure(1.0)
+
+ /**
+ * Convenient method for casting to binary logistic regression summary,
--- End diff --
Tiny grammar nit:
"""
Convenient method for casting to binary logistic regression summary.
This method will throw an Exception if the summary is not a binary summary.
"""
(This will also make tests rerun.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
