[GitHub] spark pull request #19109: Update index.md

[demoonism]

Github user demoonism closed the pull request at:

https://github.com/apache/spark/pull/19109


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19109: Update index.md

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/19109#discussion_r136711660
  
--- Diff: docs/index.md ---
@@ -24,7 +24,7 @@ source, visit [Building Spark](building-spark.html).
 
 Spark runs on both Windows and UNIX-like systems (e.g. Linux, Mac OS). 
It's easy to run
 locally on one machine --- all you need is to have `java` installed on 
your system `PATH`,
-or the `JAVA_HOME` environment variable pointing to a Java installation.
+or the `JAVA_HOME` environment variable pointing to an existing Java 
installation.
--- End diff --

I din't think this line is confusing .. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19109: Update index.md

[demoonism]

Github user demoonism commented on a diff in the pull request:

https://github.com/apache/spark/pull/19109#discussion_r136709158
  
--- Diff: docs/index.md ---
@@ -24,7 +24,7 @@ source, visit [Building Spark](building-spark.html).
 
 Spark runs on both Windows and UNIX-like systems (e.g. Linux, Mac OS). 
It's easy to run
 locally on one machine --- all you need is to have `java` installed on 
your system `PATH`,
-or the `JAVA_HOME` environment variable pointing to a Java installation.
+or the `JAVA_HOME` environment variable pointing to an existing Java 
installation.
--- End diff --

A very subtle change here. Trying to make this more "noobie friendly" by 
implying that user needs to set up JRE before running spark.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19109: Update index.md

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/19109#discussion_r136702130
  
--- Diff: docs/index.md ---
@@ -24,7 +24,7 @@ source, visit [Building Spark](building-spark.html).
 
 Spark runs on both Windows and UNIX-like systems (e.g. Linux, Mac OS). 
It's easy to run
 locally on one machine --- all you need is to have `java` installed on 
your system `PATH`,
-or the `JAVA_HOME` environment variable pointing to a Java installation.
+or the `JAVA_HOME` environment variable pointing to an existing Java 
installation.
--- End diff --

What's the ambiguity here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19109: Update index.md

[demoonism]

GitHub user demoonism opened a pull request:

https://github.com/apache/spark/pull/19109

Update index.md

Change wording to avoid confusion

## What changes were proposed in this pull request?
Change the wording in the installation doc to avoid confusion
## How was this patch tested?
Peer reviewed 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/demoonism/spark patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/19109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19109


commit 170654277c4f8130622f300f3f871751f42797dc
Author: Daniel S 
Date:   2017-09-02T19:09:20Z

Update index.md

Change wording to avoid confusion




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org