[GitHub] spark pull request #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error whe...

[jmchung]

Github user jmchung commented on a diff in the pull request:

https://github.com/apache/spark/pull/19604#discussion_r147605119
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
 ---
@@ -440,8 +440,9 @@ object JdbcUtils extends Logging {
 
 case StringType =>
   (array: Object) =>
-array.asInstanceOf[Array[java.lang.String]]
-  .map(UTF8String.fromString)
+// some underling types are not String such as uuid, inet, 
cidr, etc.
--- End diff --

Oops, a typo occurred, thanks @viirya !!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error whe...

[viirya]

Github user viirya commented on a diff in the pull request:

https://github.com/apache/spark/pull/19604#discussion_r147604947
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
 ---
@@ -440,8 +440,9 @@ object JdbcUtils extends Logging {
 
 case StringType =>
   (array: Object) =>
-array.asInstanceOf[Array[java.lang.String]]
-  .map(UTF8String.fromString)
+// some underling types are not String such as uuid, inet, 
cidr, etc.
--- End diff --

underlying?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19604: [SPARK-22291][SQL][FOLLOWUP] Conversion error whe...

[jmchung]

GitHub user jmchung opened a pull request:

https://github.com/apache/spark/pull/19604

[SPARK-22291][SQL][FOLLOWUP] Conversion error when transforming array types 
of uuid, inet and cidr to StingType in PostgreSQL

… types of uuid, inet and cidr to StingType in PostgreSQL

## What changes were proposed in this pull request?

This is a followup of #19567 , to fix the conversion error when 
transforming array types of uuid, inet and cidr to StingType in PostgreSQL for 
Spark 2.2.

## How was this patch tested?

Added test in `PostgresIntegrationSuite`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jmchung/spark SPARK-22291-FOLLOWUP

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/19604.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19604


commit 549cb814e01c2338a67c4a9efa4d880a3fb9cdac
Author: Jen-Ming Chung 
Date:   2017-10-30T01:25:28Z

[SPARK-22291][SQL][FOLLOWUP] Conversion error when transforming array types 
of uuid, inet and cidr to StingType in PostgreSQL




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org