[GitHub] spark pull request #19672: [SPARK-22456][SQL] Add support for dayofweek func...

2017-11-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/19672


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #19672: [SPARK-22456][SQL] Add support for dayofweek func...

2017-11-07 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/19672#discussion_r149493317
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
 ---
@@ -376,6 +376,7 @@ object FunctionRegistry {
 expression[DayOfMonth]("day"),
 expression[DayOfYear]("dayofyear"),
 expression[DayOfMonth]("dayofmonth"),
+expression[DayOfWeek]("dayofweek"),
--- End diff --

I think we don't need to add it again (L397)?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org