[GitHub] spark pull request #20436: [MINOR] Fix typos in dev/* scripts.
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20436 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20436: [MINOR] Fix typos in dev/* scripts.
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20436#discussion_r164758616 --- Diff: dev/lint-python --- @@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH" export "PATH=$PYTHONPATH:$PATH" # There is no need to write this output to a file -#+ first, but we do so so that the check status can -#+ be output before the report, like with the -#+ scalastyle and RAT checks. --- End diff -- Wow, thank you so much. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20436: [MINOR] Fix typos in dev/* scripts.
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/20436#discussion_r164757437 --- Diff: dev/lint-python --- @@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH" export "PATH=$PYTHONPATH:$PATH" # There is no need to write this output to a file -#+ first, but we do so so that the check status can -#+ be output before the report, like with the -#+ scalastyle and RAT checks. --- End diff -- The `#+` convention is something I picked up from [the Linux Documentation Project](http://tldp.org/LDP/abs/html/here-docs.html#COMMENTBLOCK), if that's what you're referring to. You can safely do away with it and just have the `#`. It was a "phase". I'm over it now... ð --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20436: [MINOR] Fix typos in dev/* scripts.
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20436#discussion_r164751630 --- Diff: dev/lint-python --- @@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH" export "PATH=$PYTHONPATH:$PATH" # There is no need to write this output to a file -#+ first, but we do so so that the check status can -#+ be output before the report, like with the -#+ scalastyle and RAT checks. --- End diff -- Hmm .. @nchammas, some of these seem added by you a long ago. Could you take a look for this one please? I think I am not aware of this. Wonder if we can just remove those. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20436: [MINOR] Fix typos in dev/* scripts.
Github user ashashwat commented on a diff in the pull request: https://github.com/apache/spark/pull/20436#discussion_r164749320 --- Diff: dev/lint-python --- @@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH" export "PATH=$PYTHONPATH:$PATH" # There is no need to write this output to a file -#+ first, but we do so so that the check status can -#+ be output before the report, like with the -#+ scalastyle and RAT checks. --- End diff -- Is that so? We have 100 character limit on a single line according to the style guide. Maybe all 4 lines could be rearranged? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
