[GitHub] spark pull request #20471: [SPARK-23280][SQL][FOLLOWUP] Enable `MutableColum...

2018-02-01 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20471


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20471: [SPARK-23280][SQL][FOLLOWUP] Enable `MutableColum...

2018-02-01 Thread viirya 
Github user viirya commented on a diff in the pull request:

https://github.com/apache/spark/pull/20471#discussion_r165288359
  
--- Diff: 
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnarRow.java
 ---
@@ -162,8 +162,9 @@ public ColumnarArray getArray(int ordinal) {
   }
 
   @Override
-  public MapData getMap(int ordinal) {
-throw new UnsupportedOperationException();
+  public ColumnarMap getMap(int ordinal) {
+if (columns[ordinal].isNullAt(rowId)) return null;
--- End diff --

I will remove this null check in #20455 later after this gets merged.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20471: [SPARK-23280][SQL][FOLLOWUP] Enable `MutableColum...

2018-02-01 Thread ueshin 
GitHub user ueshin opened a pull request:

https://github.com/apache/spark/pull/20471

[SPARK-23280][SQL][FOLLOWUP] Enable `MutableColumnarRow.getMap()`.

## What changes were proposed in this pull request?

This is a followup pr of #20450.
We should've enabled `MutableColumnarRow.getMap()` as well.

## How was this patch tested?

Existing tests.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ueshin/apache-spark issues/SPARK-23280/fup2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20471.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20471


commit af757ef04626df632b47b39c49ec91bdec177051
Author: Takuya UESHIN 
Date:   2018-02-01T08:19:56Z

Enable `MutableColumnarRow.getMap()`.




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org