[GitHub] spark pull request #20622: [SPARK-23441][SS] Remove queryExecutionThread.int...

[jose-torres]

Github user jose-torres commented on a diff in the pull request:

https://github.com/apache/spark/pull/20622#discussion_r168911056
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala
 ---
@@ -266,6 +263,16 @@ class ContinuousExecution(
 SQLExecution.withNewExecutionId(
   sparkSessionForQuery, lastExecution)(lastExecution.toRdd)
   }
+} catch {
+  case parentException: SparkException if parentException.getCause != 
null =>
--- End diff --

done


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20622: [SPARK-23441][SS] Remove queryExecutionThread.int...

[tdas]

Github user tdas commented on a diff in the pull request:

https://github.com/apache/spark/pull/20622#discussion_r168906511
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala
 ---
@@ -266,6 +263,16 @@ class ContinuousExecution(
 SQLExecution.withNewExecutionId(
   sparkSessionForQuery, lastExecution)(lastExecution.toRdd)
   }
+} catch {
+  case parentException: SparkException if parentException.getCause != 
null =>
--- End diff --

Can you add comments on what this code segment is doing?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20622: [SPARK-23441][SS] Remove queryExecutionThread.int...

[jose-torres]

GitHub user jose-torres opened a pull request:

https://github.com/apache/spark/pull/20622

[SPARK-23441][SS] Remove queryExecutionThread.interrupt() from 
ContinuousExecution

## What changes were proposed in this pull request?

Remove queryExecutionThread.interrupt() from ContinuousExecution. As 
detailed in the JIRA, interrupting the thread is only relevant in the 
microbatch case; for continuous processing the query execution can quickly 
clean itself up without.

## How was this patch tested?

existing tests


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jose-torres/spark SPARK-23441

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20622


commit 3d8acd2974d11a790ab9cd9338673bba18d683ac
Author: Jose Torres 
Date:   2018-02-15T17:27:09Z

remove interrupt




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org