[GitHub] spark pull request #20716: [SPARK-23566][Minor][Doc] Argument name mismatch ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20716


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20716: [SPARK-23566][Minor][Doc] Argument name mismatch ...

[animenon]

Github user animenon commented on a diff in the pull request:

https://github.com/apache/spark/pull/20716#discussion_r172024390
  
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -612,9 +614,10 @@ def repartition(self, numPartitions, *cols):
 Returns a new :class:`DataFrame` partitioned by the given 
partitioning expressions. The
 resulting DataFrame is hash partitioned.
 
-``numPartitions`` can be an int to specify the target number of 
partitions or a Column.
-If it is a Column, it will be used as the first partitioning 
column. If not specified,
-the default number of partitions is used.
+:param numPartitions:
+can be an int to specify the target number of partitions or a 
Column.
--- End diff --

Cool, was maintaining consistency with other `:param` on page.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20716: [SPARK-23566][Minor][Doc] Argument name mismatch ...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/20716#discussion_r172023219
  
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -612,9 +614,10 @@ def repartition(self, numPartitions, *cols):
 Returns a new :class:`DataFrame` partitioned by the given 
partitioning expressions. The
 resulting DataFrame is hash partitioned.
 
-``numPartitions`` can be an int to specify the target number of 
partitions or a Column.
-If it is a Column, it will be used as the first partitioning 
column. If not specified,
-the default number of partitions is used.
+:param numPartitions:
+can be an int to specify the target number of partitions or a 
Column.
--- End diff --

I think it's fine to:

```
:param numPartitions: can be an int to specify the target number of 
partitions or a Column.
If it is a Column, it will be used as the first partitioning 
column. If not specified,
```


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20716: [SPARK-23566][Minor][Doc] Argument name mismatch ...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/20716#discussion_r172023339
  
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -892,6 +896,8 @@ def colRegex(self, colName):
 def alias(self, alias):
 """Returns a new :class:`DataFrame` with an alias set.
 
+:param alias: string, alias names to be set for the DataFrame.
--- End diff --

`alias names` -> `an alias name`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20716: [SPARK-23566][Minor][Doc] Argument name mismatch ...

[animenon]

GitHub user animenon opened a pull request:

https://github.com/apache/spark/pull/20716

[SPARK-23566][Minor][Doc] Argument name mismatch fixed

Argument name mismatch fixed.

## What changes were proposed in this pull request?

`col` changed to `new` in doc string to match the argument list.

Patch file added: https://issues.apache.org/jira/browse/SPARK-23566

Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/animenon/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20716


commit 5d2bb9d0b480d7ac2a2c2d6364b87789f57856e8
Author: Anirudh 
Date:   2018-03-02T13:58:27Z

[SPARK-23566][Minor][Doc] Argument name mismatch fixed

Argument name mismatch fixed.
`col` changed to `new` in doc string to match the argument list.




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org