[GitHub] spark pull request #20818: [SPARK-23675][WEB-UI]Title add spark logo, use sp...

2018-03-14 Thread guoxiaolongzte 
GitHub user guoxiaolongzte opened a pull request:

https://github.com/apache/spark/pull/20818

[SPARK-23675][WEB-UI]Title add spark logo, use spark logo image

## What changes were proposed in this pull request?

Title add spark logo, use spark logo image. reference other big data system 
ui, so i think spark should add it.

spark fix before: 

![spark_fix_before](https://user-images.githubusercontent.com/26266482/37387866-2d5add0e-2799-11e8-9165-250f2b59df3f.png)


spark fix after: 

![spark_fix_after](https://user-images.githubusercontent.com/26266482/37387874-329e1876-2799-11e8-8bc5-c619fc1e680e.png)

 

reference kafka ui: 

![kafka](https://user-images.githubusercontent.com/26266482/37387878-35ca89d0-2799-11e8-834e-1598ae7158e1.png)

 

reference storm ui: 

![storm](https://user-images.githubusercontent.com/26266482/37387880-3854f12c-2799-11e8-8968-b428ba361995.png)

 

reference yarn ui: 

![yarn](https://user-images.githubusercontent.com/26266482/37387881-3a72e130-2799-11e8-97bb-dea85f573e95.png)

 

reference nifi ui: 

![nifi](https://user-images.githubusercontent.com/26266482/37387887-3cecfea0-2799-11e8-9a71-6c454d25840b.png)

 

reference flink ui: 

![flink](https://user-images.githubusercontent.com/26266482/37387888-3f16b1ee-2799-11e8-9d37-8355f0100548.png)

## How was this patch tested?

manual tests

Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/guoxiaolongzte/spark SPARK-23675

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20818


commit 964439be7a592b2a94f93008dabc45a18f97c3c6
Author: guoxiaolong 
Date:   2018-03-14T07:04:00Z

[SPARK-23675][WEB-UI]Title add spark logo, use spark logo image




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20818: [SPARK-23675][WEB-UI]Title add spark logo, use sp...

2018-03-19 Thread jiangxb1987 
Github user jiangxb1987 commented on a diff in the pull request:

https://github.com/apache/spark/pull/20818#discussion_r175644032
  
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -265,6 +266,7 @@ private[spark] object UIUtils extends Logging {
   
 {commonHeaderNodes}
 {if (useDataTables) dataTablesHeaderNodes else Seq.empty}
+
--- End diff --

ditto


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20818: [SPARK-23675][WEB-UI]Title add spark logo, use sp...

2018-03-19 Thread jiangxb1987 
Github user jiangxb1987 commented on a diff in the pull request:

https://github.com/apache/spark/pull/20818#discussion_r175644012
  
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -224,6 +224,7 @@ private[spark] object UIUtils extends Logging {
 {commonHeaderNodes}
 {if (showVisualization) vizHeaderNodes else Seq.empty}
 {if (useDataTables) dataTablesHeaderNodes else Seq.empty}
+
--- End diff --

Seems it should be `prependBaseUri("/static/spark-logo-77x50px-hd.png")`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20818: [SPARK-23675][WEB-UI]Title add spark logo, use sp...

2018-03-23 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/20818#discussion_r176753823
  
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -265,6 +266,7 @@ private[spark] object UIUtils extends Logging {
   
 {commonHeaderNodes}
 {if (useDataTables) dataTablesHeaderNodes else Seq.empty}
+
--- End diff --

@guoxiaolongzte don't you need to change this too?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20818: [SPARK-23675][WEB-UI]Title add spark logo, use sp...

2018-03-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20818


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org