GitHub user mangolzy opened a pull request: https://github.com/apache/spark/pull/20899
fix bug in sendMessage() of pregel implementation ## What changes were proposed in this pull request? Iterator((edge.dstId, edge.srcAttr._2 * edge.attr)) -> Iterator((edge.dstId, edge.srcAttr._1 * edge.attr)) ## How was this patch tested? Since edge.srcAttr._2 is used to compare with tol, it should be the (newPR - oldPR), but in the sendMessage, the origin code send it as part of the message, instead it should be the newPR which is edge.srcAttr._1. Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mangolzy/spark patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/20899.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20899 ---- commit be567d83c4069a0592fb61464c795d123bd34116 Author: mangolzy <ziyanliangcanton@...> Date: 2018-03-24T13:32:52Z fix bug in sendMessage() of pregel implementation Iterator((edge.dstId, edge.srcAttr._2 * edge.attr)) -> Iterator((edge.dstId, edge.srcAttr._1 * edge.attr)) Since edge.srcAttr._2 is used to compare with tol, it should be the (newPR - oldPR), but in the sendMessage, the origin code send it as part of the message, instead it should be the newPR which is edge.srcAttr._1. ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org