[GitHub] spark pull request #20998: [SPARK-23888][CORE] correct the comment of hasAtt...

2018-04-23 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20998


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20998: [SPARK-23888][CORE] correct the comment of hasAtt...

2018-04-23 Thread Ngone51 
Github user Ngone51 commented on a diff in the pull request:

https://github.com/apache/spark/pull/20998#discussion_r183408481
  
--- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -287,7 +287,7 @@ private[spark] class TaskSetManager(
 None
   }
 
-  /** Check whether a task is currently running an attempt on a given host 
*/
+  /** Check whether a task once run an attempt on a given host */
--- End diff --

Yes. Thank you.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20998: [SPARK-23888][CORE] correct the comment of hasAtt...

2018-04-23 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/20998#discussion_r183406175
  
--- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -287,7 +287,7 @@ private[spark] class TaskSetManager(
 None
   }
 
-  /** Check whether a task is currently running an attempt on a given host 
*/
+  /** Check whether a task once run an attempt on a given host */
--- End diff --

Should this be "once ran"?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org