[GitHub] spark pull request #21307: [SPARK-24186][R][SQL]change reverse and concat to...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21307 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21307: [SPARK-24186][R][SQL]change reverse and concat to...
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21307#discussion_r187822362
--- Diff: R/pkg/R/functions.R ---
@@ -2055,20 +2058,10 @@ setMethod("countDistinct",
#' @details
#' \code{concat}: Concatenates multiple input columns together into a
single column.
-#' If all inputs are binary, concat returns an output as binary.
Otherwise, it returns as string.
+#' The function works with strings, binary and compatible array columns.
--- End diff --
I think it basically mean the arrays of elements are compatibile and
castable for a wider type. (e.g. array array -> array)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21307: [SPARK-24186][R][SQL]change reverse and concat to...
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21307#discussion_r187802112
--- Diff: R/pkg/R/functions.R ---
@@ -2055,20 +2058,10 @@ setMethod("countDistinct",
#' @details
#' \code{concat}: Concatenates multiple input columns together into a
single column.
-#' If all inputs are binary, concat returns an output as binary.
Otherwise, it returns as string.
+#' The function works with strings, binary and compatible array columns.
--- End diff --
@felixcheung
I copied the sentence from scala doc. I guess it means "array columns that
have data type compatible with string and binary", but I am not sure.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21307: [SPARK-24186][R][SQL]change reverse and concat to...
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21307#discussion_r187788406
--- Diff: R/pkg/R/functions.R ---
@@ -2055,20 +2058,10 @@ setMethod("countDistinct",
#' @details
#' \code{concat}: Concatenates multiple input columns together into a
single column.
-#' If all inputs are binary, concat returns an output as binary.
Otherwise, it returns as string.
+#' The function works with strings, binary and compatible array columns.
--- End diff --
btw, what does "compatible array columns" mean?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21307: [SPARK-24186][R][SQL]change reverse and concat to...
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/21307 [SPARK-24186][R][SQL]change reverse and concat to collection functions in R ## What changes were proposed in this pull request? reverse and concat are already in functions.R as column string functions. Since now these two functions are categorized as collection functions in scala and python, we will do the same in R. ## How was this patch tested? Add test in test_sparkSQL.R You can merge this pull request into a Git repository by running: $ git pull https://github.com/huaxingao/spark spark_24186 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/21307.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21307 commit b3dd256957004621c39838b4f9eaddc431cb7bc6 Author: Huaxin Gao Date: 2018-05-11T21:40:06Z [SPARK-24186][R][SQL]change reverse and concat to collection functions in R --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
