[GitHub] spark pull request #21483: [SPARK-24477][SPARK-24454][ML][PYTHON] Imports su...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21483 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21483: [SPARK-24477][SPARK-24454][ML][PYTHON] Imports su...
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/21483#discussion_r193785229 --- Diff: python/pyspark/ml/__init__.py --- @@ -21,5 +21,11 @@ """ from pyspark.ml.base import Estimator, Model, Transformer, UnaryTransformer from pyspark.ml.pipeline import Pipeline, PipelineModel +from pyspark.ml import classification, clustering, evaluation, feature, fpm, \ +image, pipeline, recommendation, regression, stat, tuning, util -__all__ = ["Transformer", "UnaryTransformer", "Estimator", "Model", "Pipeline", "PipelineModel"] +__all__ = [ +"Transformer", "UnaryTransformer", "Estimator", "Model", "Pipeline", "PipelineModel", +"base", "classification", "clustering", "evaluation", "feature", "fpm", --- End diff -- base shouldn't be imported by default --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21483: [SPARK-24477][SPARK-24454][ML][PYTHON] Imports su...
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/21483#discussion_r193785341 --- Diff: python/pyspark/ml/__init__.py --- @@ -21,5 +21,11 @@ """ from pyspark.ml.base import Estimator, Model, Transformer, UnaryTransformer from pyspark.ml.pipeline import Pipeline, PipelineModel +from pyspark.ml import classification, clustering, evaluation, feature, fpm, \ +image, pipeline, recommendation, regression, stat, tuning, util -__all__ = ["Transformer", "UnaryTransformer", "Estimator", "Model", "Pipeline", "PipelineModel"] +__all__ = [ +"Transformer", "UnaryTransformer", "Estimator", "Model", "Pipeline", "PipelineModel", +"base", "classification", "clustering", "evaluation", "feature", "fpm", +"image", "pipeline", "recommendation", "regression", "stat", "tuning", "util", --- End diff -- we should remove `pipeline` from default imports and add `linalg` and `param`. Basically, import public modules listed here: https://spark.apache.org/docs/latest/api/python/index.html. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
