[GitHub] spark pull request #21913: [SPARK-24005][CORE] Remove usage of Scala’s par...

2018-08-07 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/21913


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21913: [SPARK-24005][CORE] Remove usage of Scala’s par...

2018-08-05 Thread MaxGekk 
Github user MaxGekk commented on a diff in the pull request:

https://github.com/apache/spark/pull/21913#discussion_r207737517
  
--- Diff: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ---
@@ -254,4 +258,58 @@ private[spark] object ThreadUtils {
   executor.shutdownNow()
 }
   }
+
+  /**
+   * Transforms input collection by applying the given function to each 
element in parallel fashion.
--- End diff --

I added a comment about this.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21913: [SPARK-24005][CORE] Remove usage of Scala’s par...

2018-08-03 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/21913#discussion_r207578729
  
--- Diff: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ---
@@ -254,4 +258,58 @@ private[spark] object ThreadUtils {
   executor.shutdownNow()
 }
   }
+
+  /**
+   * Transforms input collection by applying the given function to each 
element in parallel fashion.
--- End diff --

I'd still include a note in these docs about what this does differently 
from `.par`. Just a sentence about it being interruptible.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org