[GitHub] spark pull request #21994: [SPARK-24529][Build][test-maven][follow-up] Add s...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21994 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21994: [SPARK-24529][Build][test-maven][follow-up] Add s...
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21994#discussion_r209147728 --- Diff: pom.xml --- @@ -2609,6 +2609,28 @@ + +com.github.spotbugs +spotbugs-maven-plugin --- End diff -- let me check the elapsed time on my environment. +1 for holding on for now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21994: [SPARK-24529][Build][test-maven][follow-up] Add s...
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21994#discussion_r209145351 --- Diff: pom.xml --- @@ -2609,6 +2609,28 @@ + +com.github.spotbugs +spotbugs-maven-plugin --- End diff -- Yea, this slows down 16ish mins and that was my concern at the very first place. Currently, it only affects Maven build though. +1 for holding on for now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21994: [SPARK-24529][Build][test-maven][follow-up] Add s...
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21994#discussion_r20881 --- Diff: pom.xml --- @@ -2609,6 +2609,28 @@ + +com.github.spotbugs +spotbugs-maven-plugin --- End diff -- Adding spotbugs slows down my local build a lot. Can we hold this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21994: [SPARK-24529][Build][test-maven][follow-up] Add s...
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21994#discussion_r207732745 --- Diff: pom.xml --- @@ -2609,6 +2609,28 @@ + +com.github.spotbugs +spotbugs-maven-plugin --- End diff -- Oh, I have not tried this with parallel build. Spotbugs looks [non MT-safe](https://github.com/spotbugs/spotbugs/issues/249) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21994: [SPARK-24529][Build][test-maven][follow-up] Add s...
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21994#discussion_r207729852 --- Diff: pom.xml --- @@ -2609,6 +2609,28 @@ + +com.github.spotbugs +spotbugs-maven-plugin --- End diff -- Actually, after having this plugin, I were unable to perform parallel builds. https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21994: [SPARK-24529][Build][test-maven][follow-up] Add s...
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21994#discussion_r207729865 --- Diff: pom.xml --- @@ -2609,6 +2609,28 @@ + +com.github.spotbugs +spotbugs-maven-plugin --- End diff -- It sounds like this plug in is not thread safe. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21994: [SPARK-24529][Build][test-maven][follow-up] Add s...
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/21994 [SPARK-24529][Build][test-maven][follow-up] Add spotbugs 3.1.6 into maven build process ## What changes were proposed in this pull request? This PR tries to add spotbugs after [upgrading mvn](https://issues.apache.org/jira/browse/SPARK-24956). This is because we met [a problem](https://issues.apache.org/jira/browse/SPARK-24895) with old mvn. ## How was this patch tested? existing UTs You can merge this pull request into a Git repository by running: $ git pull https://github.com/kiszk/spark SPARK-24529-follow Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/21994.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21994 commit 3501209badca1c4d38e4ca7d0ddc45d2977e34e0 Author: Kazuaki Ishizaki Date: 2018-08-03T21:24:21Z add spotbugs 3.1.6 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
