[GitHub] spark pull request #22120: [SPARK-25131]Event logs missing applicationAttemp...

2018-08-19 Thread ajithme 
Github user ajithme closed the pull request at:

https://github.com/apache/spark/pull/22120


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22120: [SPARK-25131]Event logs missing applicationAttemp...

2018-08-16 Thread sujith71955 
Github user sujith71955 commented on a diff in the pull request:

https://github.com/apache/spark/pull/22120#discussion_r210599272
  
--- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
 ---
@@ -62,6 +62,10 @@ private[spark] class YarnClientSchedulerBackend(
 super.start()
 waitForApplication()
 
+// set the attemptId as its available now
+this.attemptId = Option(client.getApplicationReport(this.appId.get)
+  .getCurrentApplicationAttemptId())
+
--- End diff --

Extra space


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22120: [SPARK-25131]Event logs missing applicationAttemp...

2018-08-16 Thread ajithme 
GitHub user ajithme opened a pull request:

https://github.com/apache/spark/pull/22120

[SPARK-25131]Event logs missing applicationAttemptId for 
SparkListenerApplicationStart

When master=yarn and deploy-mode=client, event logs do not contain 
applicationAttemptId for SparkListenerApplicationStart. This is caused at 
org.apache.spark.scheduler.cluster.YarnClientSchedulerBackend#start where we do 
bindToYarn(client.submitApplication(), None) which sets appAttemptId to None. 
We can however, get the appAttemptId after waitForApplication() and set it


This i have tested manually and verified

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ajithme/spark missingAttemptId

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/22120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22120


commit cc7625c06609c1092ca26d6d6b4f522b9f844710
Author: Ajith 
Date:   2018-08-16T12:54:06Z

Set application attempt id in yarn client mode




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org