[GitHub] spark pull request #22398: [SPARK-23820][CORE] Enable use of long form of ca...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22398 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22398: [SPARK-23820][CORE] Enable use of long form of ca...
Github user michaelmior commented on a diff in the pull request: https://github.com/apache/spark/pull/22398#discussion_r217013397 --- Diff: docs/configuration.md --- @@ -746,6 +746,13 @@ Apart from these, the following properties are also available, and may be useful *Warning*: This will increase the size of the event log considerably. + + spark.eventLog.longForm.enabled + false + +Whether to use the long form of call sites in the event log. --- End diff -- Changed. I was thinking the behaviour on false was implicit, but nothing wrong with being explicit anyway :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22398: [SPARK-23820][CORE] Enable use of long form of ca...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22398#discussion_r216882861 --- Diff: docs/configuration.md --- @@ -746,6 +746,13 @@ Apart from these, the following properties are also available, and may be useful *Warning*: This will increase the size of the event log considerably. + + spark.eventLog.longForm.enabled + false + +Whether to use the long form of call sites in the event log. --- End diff -- This seems fine. If you have to change anything, I might say this as "If true, use the long form of call sites in the event log. Otherwise use the short form." Just to clarify what long form is an alternative to. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22398: [SPARK-23820][CORE] Enable use of long form of ca...
GitHub user michaelmior opened a pull request: https://github.com/apache/spark/pull/22398 [SPARK-23820][CORE] Enable use of long form of callsite in logs This is a rework of #21433 to address some concerns there. You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelmior/spark long-callsite2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22398.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22398 commit 15edc21325f4d6cd249626032aae621880aaf75a Author: Michael Mior Date: 2018-03-28T20:57:41Z [SPARK-23820][CORE] Enable use of long form of callsite in logs --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
