[GitHub] spark pull request #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterS...

2018-09-18 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/22452


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterS...

2018-09-18 Thread squito 
Github user squito commented on a diff in the pull request:

https://github.com/apache/spark/pull/22452#discussion_r218496943
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/python/PythonForeachWriterSuite.scala
 ---
@@ -75,15 +78,20 @@ class PythonForeachWriterSuite extends SparkFunSuite 
with Eventually {
 tester = new BufferTester(memBytes, sleepPerRowReadMs)
 f(tester)
   } finally {
-if (tester == null) tester.close()
+if (tester != null) tester.close()
--- End diff --

yes, but that NPE just covered up another NPE from 
`SparkEnv.get.serializerManager`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterS...

2018-09-18 Thread squito 
GitHub user squito opened a pull request:

https://github.com/apache/spark/pull/22452

[SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite

PythonForeachWriterSuite was failing because RowQueue now needs to have a 
handle on a SparkEnv with a SerializerManager, so added a mock env with a 
serializer manager.

Also fixed a typo in the `finally` that was hiding the real exception.

Tested PythonForeachWriterSuite locally, full tests via jenkins.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/squito/spark SPARK-25456

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/22452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22452


commit 33725ce4f8632fbb12e9707e71d5cb897e3b6038
Author: Imran Rashid 
Date:   2018-09-18T14:22:57Z

[SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org