[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22668 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Github user shivusondur commented on a diff in the pull request:
https://github.com/apache/spark/pull/22668#discussion_r224337547
--- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
@@ -154,9 +150,6 @@ private[ui] trait PagedTable[T] {
* }}}
*/
private[ui] def pageNavigation(page: Int, pageSize: Int, totalPages:
Int): Seq[Node] = {
-if (totalPages == 1) {
- Nil
-} else {
--- End diff --
Thanks for reviewing,
handled your comment, showing more difference because of white-space.
please check
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22668#discussion_r224323509
--- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
@@ -154,9 +150,6 @@ private[ui] trait PagedTable[T] {
* }}}
*/
private[ui] def pageNavigation(page: Int, pageSize: Int, totalPages:
Int): Seq[Node] = {
-if (totalPages == 1) {
- Nil
-} else {
--- End diff --
One more comment: need to adjust the indent of the following code block.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Github user shivusondur commented on a diff in the pull request:
https://github.com/apache/spark/pull/22668#discussion_r224318421
--- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
@@ -123,10 +123,9 @@ private[ui] trait PagedTable[T] {
/**
* Return a page navigation.
*
- * If the totalPages is 1, the page navigation will be empty
*
- * If the totalPages is more than 1, it will create a page
navigation including a group of
- * page numbers and a form to submit the page number.
+ * It will create a page navigation including a group of page
numbers and a form
--- End diff --
@gengliangwang @felixcheung
i have updated according to your suggestion. please check.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22668#discussion_r224316034
--- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
@@ -123,10 +123,9 @@ private[ui] trait PagedTable[T] {
/**
* Return a page navigation.
*
- * If the totalPages is 1, the page navigation will be empty
*
- * If the totalPages is more than 1, it will create a page
navigation including a group of
- * page numbers and a form to submit the page number.
+ * It will create a page navigation including a group of page
numbers and a form
--- End diff --
true.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22668#discussion_r224101829
--- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
@@ -123,10 +123,9 @@ private[ui] trait PagedTable[T] {
/**
* Return a page navigation.
*
- * If the totalPages is 1, the page navigation will be empty
*
- * If the totalPages is more than 1, it will create a page
navigation including a group of
- * page numbers and a form to submit the page number.
+ * It will create a page navigation including a group of page
numbers and a form
--- End diff --
I don't think we need to put this comment inside `..`
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...
GitHub user shivusondur opened a pull request: https://github.com/apache/spark/pull/22668 [SPARK-25675] [Spark Job History] Job UI page does not show pagination with one page ## What changes were proposed in this pull request? Currently in PagedTable.scala pageNavigation() method, if it is having only one page, they were not using the pagination. Now it made to use the pagination, even if it is having one page. ## How was this patch tested? This tested with Spark webUI and History page in spark local setup. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shivusondur/spark pagination Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22668.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22668 commit 08328c9fd41787b0bd6c81d077f6d917d57690a2 Author: shivusondur Date: 2018-10-08T04:32:28Z [SPARK-25675] [Spark Job History] Job UI page does not show pagination with one page Removed the check for single page and made to show pagination for even single page --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
