[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22678 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22678#discussion_r224549100 --- Diff: docs/building-spark.md --- @@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g. 2.12.6): ./build/sbt -Dscala.version=2.12.6 Otherwise, the sbt-pom-reader plugin will use the `scala.version` specified in the spark-parent pom. + +## Running Jenkins tests with Github Enterprise + +To run tests with Jenkins: + +./dev/run-tests-jenkins + +If use an individual repository or an GitHub Enterprise, export below environment variables before running above command. + +### Related environment variables + + +Variable NameDefaultMeaning + + GITHUB_API_BASE + https://api.github.com/repos/apache/spark + +The GitHub server API URL. It could be pointed to an GitHub Enterprise. --- End diff -- nit: `an` -> `a` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22678#discussion_r224549012 --- Diff: docs/building-spark.md --- @@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g. 2.12.6): ./build/sbt -Dscala.version=2.12.6 Otherwise, the sbt-pom-reader plugin will use the `scala.version` specified in the spark-parent pom. + +## Running Jenkins tests with Github Enterprise + +To run tests with Jenkins: + +./dev/run-tests-jenkins + +If use an individual repository or an GitHub Enterprise, export below environment variables before running above command. --- End diff -- nit: `an` -> `a` In addition, how about `an GitHub Enterprise` -> `a repository on GitHub Enterprise`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22678#discussion_r22445 --- Diff: docs/building-spark.md --- @@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g. 2.12.6): ./build/sbt -Dscala.version=2.12.6 Otherwise, the sbt-pom-reader plugin will use the `scala.version` specified in the spark-parent pom. + +## Running Jenkins tests with enterprise Github + +To run tests with Jenkins: + +./dev/run-tests-jenkins + +If use an individual repository or an enterprise GitHub, export below environment variables before running above command. + +### Related environment variables + + +Variable NameDefaultMeaning + + GITHUB_API_BASE + https://api.github.com/repos/apache/spark + +The GitHub server API URL. It could be pointed to an enterprise GitHub. + + + + SPARK_PROJECT_URL + https://github.com/apache/spark + +The Spark project URL of (enterprise) GitHub. --- End diff -- ditto --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22678#discussion_r224333028 --- Diff: docs/building-spark.md --- @@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g. 2.12.6): ./build/sbt -Dscala.version=2.12.6 Otherwise, the sbt-pom-reader plugin will use the `scala.version` specified in the spark-parent pom. + +## Running Jenkins tests with enterprise Github + +To run tests with Jenkins: + +./dev/run-tests-jenkins + +If use an individual repository or an enterprise GitHub, export below environment variables before running above command. + +### Related environment variables + + +Variable NameDefaultMeaning + + GITHUB_API_BASE + https://api.github.com/repos/apache/spark + +The GitHub server API URL. It could be pointed to an enterprise GitHub. --- End diff -- ditto --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22678#discussion_r224332828 --- Diff: docs/building-spark.md --- @@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g. 2.12.6): ./build/sbt -Dscala.version=2.12.6 Otherwise, the sbt-pom-reader plugin will use the `scala.version` specified in the spark-parent pom. + +## Running Jenkins tests with enterprise Github --- End diff -- nit: `enterprise Github` -> `GitHub Enterprise` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22678#discussion_r224332984 --- Diff: docs/building-spark.md --- @@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g. 2.12.6): ./build/sbt -Dscala.version=2.12.6 Otherwise, the sbt-pom-reader plugin will use the `scala.version` specified in the spark-parent pom. + +## Running Jenkins tests with enterprise Github + +To run tests with Jenkins: + +./dev/run-tests-jenkins + +If use an individual repository or an enterprise GitHub, export below environment variables before running above command. --- End diff -- ditto --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22678#discussion_r224327625 --- Diff: docs/building-spark.md --- @@ -272,3 +272,31 @@ For SBT, specify a complete scala version using (e.g. 2.12.6): ./build/sbt -Dscala.version=2.12.6 Otherwise, the sbt-pom-reader plugin will use the `scala.version` specified in the spark-parent pom. + +## Running Jenkins tests with enterprise Github + +To run tests with Jenkins: + +./dev/run-tests-jenkins + +If you use an individual repository or an enterprise GitHub, you should export below environment variables before running above command. + +### Related environment variables + + +variable NameDefaultMeaning --- End diff -- `variable` -> `Variable` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user LantaoJin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r224309582
--- Diff: dev/run-tests-jenkins.py ---
@@ -39,7 +39,8 @@ def print_err(msg):
def post_message_to_github(msg, ghprb_pull_id):
print("Attempting to post to Github...")
-url = "https://api.github.com/repos/apache/spark/issues/"; +
ghprb_pull_id + "/comments"
+api_url = os.getenv("GITHUB_SERVER_API_URL",
"https://api.github.com/repos/apache/spark";)
--- End diff --
Sure. @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r224172678
--- Diff: dev/run-tests-jenkins.py ---
@@ -176,7 +177,8 @@ def main():
build_display_name = os.environ["BUILD_DISPLAY_NAME"]
build_url = os.environ["BUILD_URL"]
-commit_url = "https://github.com/apache/spark/commit/"; +
ghprb_actual_commit
+project_url = os.getenv("SPARK_PROJECT_URL",
"https://github.com/apache/spark";)
+commit_url = project_url + "/commit/" + ghprb_actual_commit
--- End diff --
+1
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user LantaoJin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r223966833
--- Diff: dev/run-tests-jenkins.py ---
@@ -176,7 +177,8 @@ def main():
build_display_name = os.environ["BUILD_DISPLAY_NAME"]
build_url = os.environ["BUILD_URL"]
-commit_url = "https://github.com/apache/spark/commit/"; +
ghprb_actual_commit
+project_url = os.getenv("SPARK_PROJECT_URL",
"https://github.com/apache/spark";)
+commit_url = project_url + "/commit/" + ghprb_actual_commit
--- End diff --
How about to add documentation at
https://spark.apache.org/docs/latest/building-spark.html?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r223917766
--- Diff: dev/run-tests-jenkins.py ---
@@ -39,7 +39,8 @@ def print_err(msg):
def post_message_to_github(msg, ghprb_pull_id):
print("Attempting to post to Github...")
-url = "https://api.github.com/repos/apache/spark/issues/"; +
ghprb_pull_id + "/comments"
+api_url = os.getenv("GITHUB_SERVER_API_URL",
"https://api.github.com/repos/apache/spark";)
--- End diff --
How about `GITHUB_API_BASE`? This is because [another
script](https://github.com/apache/spark/blob/master/dev/github_jira_sync.py#L35)
uses this name for this URL.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22678: [SPARK-25685][BUILD] Allow running tests in Jenki...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22678#discussion_r223845057
--- Diff: dev/run-tests-jenkins.py ---
@@ -176,7 +177,8 @@ def main():
build_display_name = os.environ["BUILD_DISPLAY_NAME"]
build_url = os.environ["BUILD_URL"]
-commit_url = "https://github.com/apache/spark/commit/"; +
ghprb_actual_commit
+project_url = os.getenv("SPARK_PROJECT_URL",
"https://github.com/apache/spark";)
+commit_url = project_url + "/commit/" + ghprb_actual_commit
--- End diff --
Looks good. BTW, do we need to add some dev documentation for this useful
new configuration; `GITHUB_SERVER_API_URL` and `SPARK_PROJECT_URL`? Is this
targeting too specific users?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
